Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LossModel.getCombinedG() always adds default value of 1 for total fatalities #264

Open
mhearne-usgs opened this issue Apr 23, 2020 · 0 comments

Comments

@mhearne-usgs
Copy link
Member

Our combined G value is going to be off by a little bit because we're passing in a loss dictionary which contains total losses. the getModel() method treats "TotalDollars" as a country code it doesn't know about and assigns it an L2G value of 1.0.

This means for a lossdict that looks like: {'EU': 0, 'WU': 68376, 'TotalDollars': 68376}

you get a combined G of 2.69 where it should be 2.5 (the L2G value for WU).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant