diff --git a/.github/workflows/build-android.yml b/.github/workflows/build-android.yml index afceab3c..97bd7e01 100644 --- a/.github/workflows/build-android.yml +++ b/.github/workflows/build-android.yml @@ -46,9 +46,9 @@ jobs: - name: Install dependencies and prepare assets run: yarn install && npx react-native-asset - name: Bundle the JS - run: npx react-native bundle --platform android --entry-file ./index.js --bundle-output android/app/src/main/assets/index.android.bundle --assets-dest android/app/src/main/res + run: yarn react-native bundle --platform android --entry-file ./index.js --bundle-output android/app/src/main/assets/index.android.bundle --assets-dest android/app/src/main/res - name: Build the app - run: npx react-native build-android --tasks assembleDebug + run: yarn react-native build-android --tasks assembleDebug - name: Rename debug APKs run: | mv app-arm64-v8a-debug.apk RVMob-Debug-${{ github.sha }}-arm64-v8a.apk diff --git a/package.json b/package.json index 80d795c5..8c34c7c1 100644 --- a/package.json +++ b/package.json @@ -12,7 +12,7 @@ "test": "jest", "lint": "eslint .", "web": "webpack-dev-server --config webpack.config.js --hot --mode=development", - "web-release": "webpack --config webpack.config.js", + "web-release": "webpack --config webpack.config.js --mode=production", "postinstall": "patch-package" }, "dependencies": { diff --git a/webpack.config.js b/webpack.config.js index 62bfd656..3cb19370 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -98,6 +98,7 @@ module.exports = { plugins: [ new HtmlWebpackPlugin({ template: path.join(__dirname, 'web/index.html'), + favicon: path.join(__dirname, 'public/favicon.ico'), }), new webpack.DefinePlugin({ // See: https://github.com/necolas/react-native-web/issues/349