Date assert should be able to handle unix timestamp

[madeiras]

No description provided.

[ruimarinho]

@JoaoHenriquePereira can you submit a PR adding moment parse to each Date assert instead of what's being done currently?

[madeiras]

Actually I took some time today to think about this. WDYT something like this:

this.validate = value => {
    if (typeof value === 'string') {
      if (isNaN(Date.parse(value)) === true) {
        throw new Violation(this, value);
      }

      return true;
    }

    if (typeof value === 'number') {
      if (new Date(value).getTime() < 0) {
        throw new Violation(this, value);
      }

      return true;
    }

    if (Object.prototype.toString.call(value) !== '[object Date]') {
      throw new Violation(this, value, { value: 'must_be_a_date_or_a_string_or_a_timestamp' });
    }

    return true;
  };

It keeps compatibility, adds support to evaluate a timestamp and evaluates a Date object in similar fashion to moment isDate (as before). The caveat I see is the number being anything and being parsed as a timestamp.... Might be easier to just trust moment though I haven't explored thoroughly yet.

[madeiras]

Update: Ok noticed you changed the assert already :) I'll update later what needs to be done.

[ruimarinho]

Something like that would work, yes. That would work for server as minor, otherwise adding moment has the caveat of making it a major (requires additional peer dependency).

[ruimarinho]

Note this from MDN:

Date.prototype.getTime()

Returns the numeric value of the specified date as the number of milliseconds since January 1, 1970, 00:00:00 UTC (negative for prior times).

[madeiras]

I'll have a look on how I could add support for negative dates and submit a PR.