Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accounts #42

Open
julien51 opened this issue Apr 30, 2020 · 3 comments
Open

Accounts #42

julien51 opened this issue Apr 30, 2020 · 3 comments

Comments

@julien51
Copy link
Member

We currently require an injected wallet... which is very annoying because only a very small fraction of web users have an injected wallet.
We need to support the following:

  • If there is an injected wallet, default to that one, but let users pick another one.
  • If there is no injected wallet, let the user use something like WalletConnect to connect their other existing wallet, or use a "hosted wallet" such as Fortmatic or Portis or Bitski.
@julien51
Copy link
Member Author

It looks like https://github.com/aragon/use-wallet provides the exact level of abstraction/customization that were looking for.

@julien51
Copy link
Member Author

After diving a bit deeper it looks https://github.com/NoahZinsmeister/web3-react (on which use-wallet is built) is both more maintained and richer so that's what we're using!

@julien51
Copy link
Member Author

julien51 commented Jun 16, 2020 •
edited
Loading

We now use @web3-react with the injected connector.
Next, we need to add support for WalletConnect and for Magic by Fortmatic: Uniswap/web3-react#101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@julien51