Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Out-of-order merge process #1

Open
nderjung opened this issue Feb 2, 2022 · 0 comments
Open

Out-of-order merge process #1

nderjung opened this issue Feb 2, 2022 · 0 comments

Comments

@nderjung
Copy link
Member

nderjung commented Feb 2, 2022

A merge with an invalid email occured on the Unikraft core repo. This should not have happened and now the commit messages has an invalid email address associated with it.

The result here is the failure of several things:

  • lack of documentation for Jianyong on how to review a PR (resolved this week with the documentation website is made live);
  • The CI picking up your comment as review (at the moment comments AND reviews) -- difficult to determine because people's github names and the one they comment with the Reviewed-by tag may differ
  • The approval comment should come after the review comment, in this case, both were detected.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant