C++ State Machine Library #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crypt1cG
reviewed
Nov 25, 2024
Crypt1cG
reviewed
Nov 25, 2024
Crypt1cG
reviewed
Dec 6, 2024
qhdwight
reviewed
Dec 6, 2024
|
|
||
| std::vector<std::reference_wrapper<std::type_info const>> types{std::ref(typeid(To))...}; | ||
| for(auto const& type : types){ | ||
| demangledName = abi::__cxa_demangle(type.get().name(), nullptr, nullptr, &status); |
There was a problem hiding this comment.
its c++filt... but in C++ 💯
There was a problem hiding this comment.
This is unholy. Just have states carry a static member for the name...
There was a problem hiding this comment.
unholy is harsh... 😢 but it is p cool 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #34
What features did you add, bugs did you fix, etc?
Added a C++ State Machine Library
Did you add documentation to the wiki?
No
How was this code tested?
Created a test state machine with two states which had non-trivial constructors. They then transitioned between themselves. Made sure all of the static asserts caught invalid states. Updated visualizer.py to interface with multiple state publishers.
Did you test this in sim?
No, sim is not explicitly involved in a state machine
Did you test this on the rover?
No, the rover is not explicitly involved in a state machine
Did you add unit tests?
No