Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce number of symbols in Telegram messages #1587

Open
paskal opened this issue Jan 19, 2023 · 3 comments · May be fixed by #1870
Open

Reduce number of symbols in Telegram messages #1587

paskal opened this issue Jan 19, 2023 · 3 comments · May be fixed by #1870
Labels
backend enhancement good-first-issue help wanted

Comments

@paskal
Copy link
Collaborator

paskal commented Jan 19, 2023

It makes sense not to cite long messages in Telegram, leaving 50 or 100 messages should be enough.
@paskal paskal added the backend label Jan 19, 2023
@paskal paskal added this to the v1.11.3 milestone Jan 19, 2023
@paskal paskal self-assigned this Jan 19, 2023
@paskal paskal removed this from the v1.11.3 milestone Jan 21, 2023
@paskal
Copy link
Collaborator Author

paskal commented Sep 16, 2023

The problem here is that a telegram message is HTML, so cutting it requires HTML parsing and not just cutting by the number of symbols. Also, ideally, we should not count HTML tags which don't consume screen space but only alter the appearance of the text.

@paskal paskal removed their assignment Sep 16, 2023
@HARDY8118
Copy link

Hi @paskal

Can you provide some more background on the issue.

@paskal
Copy link
Collaborator Author

paskal commented Feb 14, 2024

@HARDY8118, what kind of details do you need? The issue is that messages are sometimes unnecessarily long and should be truncated, but it's tricky as they are HTML and not just text.

aliksend added a commit to aliksend/remark42 that referenced this issue Dec 5, 2024
@aliksend
Implement function to prune string keeping HTML closing tags
d80eae7 
Fixes umputun#1587
@aliksend aliksend linked a pull request Dec 5, 2024 that will close this issue
Open
aliksend added a commit to aliksend/remark42 that referenced this issue Dec 17, 2024
@aliksend
Implement function to prune string keeping HTML closing tags
f5283cc 
Fixes umputun#1587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend enhancement good-first-issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement function to prune string keeping HTML closing tags aliksend/remark42
2 participants
@paskal @HARDY8118