From 0daa3665b5df8027fb5eae1b86bff1f168440b23 Mon Sep 17 00:00:00 2001 From: Jonathan Date: Mon, 20 Jan 2025 14:58:56 +0100 Subject: [PATCH 1/5] Updated the dialog label User - Assign Access - Media Start nodes --- src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts | 5 +++++ src/Umbraco.Web.UI.Client/src/assets/lang/en-us.ts | 5 +++++ src/Umbraco.Web.UI.Client/src/assets/lang/en.ts | 5 +++++ .../media/modals/media-picker/media-picker-modal.element.ts | 4 ++-- 4 files changed, 17 insertions(+), 2 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts b/src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts index b596ded3f9d9..708e3e79b6b7 100644 --- a/src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts +++ b/src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts @@ -123,6 +123,7 @@ export default { buttons: { clearSelection: 'Ryd valg', select: 'Vælg', + choose: 'Vælg', somethingElse: 'Gør noget andet', bold: 'Fed', deindent: 'Fortryd indryk afsnit', @@ -535,6 +536,7 @@ export default { linkToMedia: 'Link til medie', selectContentStartNode: 'Vælg startnode for indhold', selectMedia: 'Vælg medie', + chooseMedia: 'Vælg medie', selectMediaType: 'Vælg medietype', selectIcon: 'Vælg ikon', selectItem: 'Vælg item', @@ -1919,6 +1921,9 @@ export default { selectUserGroup: (multiple: boolean) => { return multiple ? 'Vælg brugergrupper' : 'Vælg brugergruppe'; }, + chooseUserGroup: (multiple: boolean) => { + return multiple ? 'Vælg brugergrupper' : 'Vælg brugergruppe'; + }, noStartNode: 'Ingen startnode valgt', noStartNodes: 'Ingen startnoder valgt', startnode: 'Indhold startnode', diff --git a/src/Umbraco.Web.UI.Client/src/assets/lang/en-us.ts b/src/Umbraco.Web.UI.Client/src/assets/lang/en-us.ts index 6f53e1ba9ff6..4fe64bd51fb0 100644 --- a/src/Umbraco.Web.UI.Client/src/assets/lang/en-us.ts +++ b/src/Umbraco.Web.UI.Client/src/assets/lang/en-us.ts @@ -129,6 +129,7 @@ export default { buttons: { clearSelection: 'Clear selection', select: 'Select', + choose: 'Choose', somethingElse: 'Do something else', bold: 'Bold', deindent: 'Cancel Paragraph Indent', @@ -567,6 +568,7 @@ export default { linkToMedia: 'Link to media', selectContentStartNode: 'Select content start node', selectMedia: 'Select media', + chooseMedia: 'Choose media', selectMediaType: 'Select media type', selectIcon: 'Select icon', selectItem: 'Select item', @@ -1971,6 +1973,9 @@ export default { selectUserGroup: (multiple: boolean) => { return multiple ? 'Select User Groups' : 'Select User Group'; }, + chooseUserGroup: (multiple: boolean) => { + return multiple ? 'Choose User Groups' : 'Choose User Group'; + }, noStartNode: 'No start node selected', noStartNodes: 'No start nodes selected', startnode: 'Content start node', diff --git a/src/Umbraco.Web.UI.Client/src/assets/lang/en.ts b/src/Umbraco.Web.UI.Client/src/assets/lang/en.ts index fab754e4626d..cc96c0f0310c 100644 --- a/src/Umbraco.Web.UI.Client/src/assets/lang/en.ts +++ b/src/Umbraco.Web.UI.Client/src/assets/lang/en.ts @@ -129,6 +129,7 @@ export default { buttons: { clearSelection: 'Clear selection', select: 'Select', + choose: 'Choose', somethingElse: 'Do something else', bold: 'Bold', deindent: 'Cancel Paragraph Indent', @@ -558,6 +559,7 @@ export default { selectContentStartNode: 'Select content start node', selectEvent: 'Select event', selectMedia: 'Select media', + chooseMedia: 'Choose media', selectMediaType: 'Select media type', selectIcon: 'Select icon', selectItem: 'Select item', @@ -2010,6 +2012,9 @@ export default { selectUserGroup: (multiple: boolean) => { return multiple ? 'Select User Groups' : 'Select User Group'; }, + chooseUserGroup: (multiple: boolean) => { + return multiple ? 'Choose User Groups' : 'Choose User Group'; + }, noStartNode: 'No start node selected', noStartNodes: 'No start nodes selected', startnode: 'Content start node', diff --git a/src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/media-picker-modal.element.ts b/src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/media-picker-modal.element.ts index 6508d21c7a2f..72cfe7ca301a 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/media-picker-modal.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/media-picker-modal.element.ts @@ -229,12 +229,12 @@ export class UmbMediaPickerModalElement extends UmbModalBaseElement< override render() { return html` - + ${this.#renderBody()} ${this.#renderBreadcrumb()}
From d46ab488ffe3c1da0802c078fcac60bcf25823bf Mon Sep 17 00:00:00 2001 From: Jonathan Date: Mon, 20 Jan 2025 15:05:51 +0100 Subject: [PATCH 2/5] Minor change to the modal headline --- src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts | 2 +- src/Umbraco.Web.UI.Client/src/assets/lang/en-us.ts | 2 +- src/Umbraco.Web.UI.Client/src/assets/lang/en.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts b/src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts index 708e3e79b6b7..2c487e785058 100644 --- a/src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts +++ b/src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts @@ -536,7 +536,7 @@ export default { linkToMedia: 'Link til medie', selectContentStartNode: 'Vælg startnode for indhold', selectMedia: 'Vælg medie', - chooseMedia: 'Vælg medie', + chooseMedia: 'Vælg medie start node', selectMediaType: 'Vælg medietype', selectIcon: 'Vælg ikon', selectItem: 'Vælg item', diff --git a/src/Umbraco.Web.UI.Client/src/assets/lang/en-us.ts b/src/Umbraco.Web.UI.Client/src/assets/lang/en-us.ts index 4fe64bd51fb0..2e895a9a4a8b 100644 --- a/src/Umbraco.Web.UI.Client/src/assets/lang/en-us.ts +++ b/src/Umbraco.Web.UI.Client/src/assets/lang/en-us.ts @@ -568,7 +568,7 @@ export default { linkToMedia: 'Link to media', selectContentStartNode: 'Select content start node', selectMedia: 'Select media', - chooseMedia: 'Choose media', + chooseMedia: 'Choose Media Start nodes', selectMediaType: 'Select media type', selectIcon: 'Select icon', selectItem: 'Select item', diff --git a/src/Umbraco.Web.UI.Client/src/assets/lang/en.ts b/src/Umbraco.Web.UI.Client/src/assets/lang/en.ts index cc96c0f0310c..5692a0571424 100644 --- a/src/Umbraco.Web.UI.Client/src/assets/lang/en.ts +++ b/src/Umbraco.Web.UI.Client/src/assets/lang/en.ts @@ -559,7 +559,7 @@ export default { selectContentStartNode: 'Select content start node', selectEvent: 'Select event', selectMedia: 'Select media', - chooseMedia: 'Choose media', + chooseMedia: 'Choose Media Start nodes', selectMediaType: 'Select media type', selectIcon: 'Select icon', selectItem: 'Select item', From bdb85cd68ac4bb188789dd1b2bd229bbb69bb461 Mon Sep 17 00:00:00 2001 From: Jonathan Date: Mon, 20 Jan 2025 15:40:38 +0100 Subject: [PATCH 3/5] update based on review. --- src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts b/src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts index 2c487e785058..04abbc8e3618 100644 --- a/src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts +++ b/src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts @@ -536,7 +536,7 @@ export default { linkToMedia: 'Link til medie', selectContentStartNode: 'Vælg startnode for indhold', selectMedia: 'Vælg medie', - chooseMedia: 'Vælg medie start node', + chooseMedia: 'Vælg medie startnode', selectMediaType: 'Vælg medietype', selectIcon: 'Vælg ikon', selectItem: 'Vælg item', From f6b6169860af89bfdf220a6638ec7bddb385afbc Mon Sep 17 00:00:00 2001 From: Jonathan Date: Wed, 22 Jan 2025 09:20:38 +0100 Subject: [PATCH 4/5] updated the languages based on review --- src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts | 2 +- src/Umbraco.Web.UI.Client/src/assets/lang/en-us.ts | 2 +- src/Umbraco.Web.UI.Client/src/assets/lang/en.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts b/src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts index 04abbc8e3618..491fffcbff4f 100644 --- a/src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts +++ b/src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts @@ -536,7 +536,7 @@ export default { linkToMedia: 'Link til medie', selectContentStartNode: 'Vælg startnode for indhold', selectMedia: 'Vælg medie', - chooseMedia: 'Vælg medie startnode', + chooseMediaStartNode: 'Vælg medie startnode', selectMediaType: 'Vælg medietype', selectIcon: 'Vælg ikon', selectItem: 'Vælg item', diff --git a/src/Umbraco.Web.UI.Client/src/assets/lang/en-us.ts b/src/Umbraco.Web.UI.Client/src/assets/lang/en-us.ts index 2e895a9a4a8b..f02c3b561ac0 100644 --- a/src/Umbraco.Web.UI.Client/src/assets/lang/en-us.ts +++ b/src/Umbraco.Web.UI.Client/src/assets/lang/en-us.ts @@ -568,7 +568,7 @@ export default { linkToMedia: 'Link to media', selectContentStartNode: 'Select content start node', selectMedia: 'Select media', - chooseMedia: 'Choose Media Start nodes', + chooseMediaStartNode: 'Choose Media Start nodes', selectMediaType: 'Select media type', selectIcon: 'Select icon', selectItem: 'Select item', diff --git a/src/Umbraco.Web.UI.Client/src/assets/lang/en.ts b/src/Umbraco.Web.UI.Client/src/assets/lang/en.ts index 5692a0571424..f6373ee12fc7 100644 --- a/src/Umbraco.Web.UI.Client/src/assets/lang/en.ts +++ b/src/Umbraco.Web.UI.Client/src/assets/lang/en.ts @@ -559,7 +559,7 @@ export default { selectContentStartNode: 'Select content start node', selectEvent: 'Select event', selectMedia: 'Select media', - chooseMedia: 'Choose Media Start nodes', + chooseMediaStartNode: 'Choose Media Start nodes', selectMediaType: 'Select media type', selectIcon: 'Select icon', selectItem: 'Select item', From e0f4b0e7db3622ee6c9e6ba0a989d38d9c8ea433 Mon Sep 17 00:00:00 2001 From: Jonathan Date: Wed, 22 Jan 2025 09:22:41 +0100 Subject: [PATCH 5/5] updated based on review --- .../media/modals/media-picker/media-picker-modal.element.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/media-picker-modal.element.ts b/src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/media-picker-modal.element.ts index 72cfe7ca301a..2ae3f6231be2 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/media-picker-modal.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/media-picker-modal.element.ts @@ -229,7 +229,7 @@ export class UmbMediaPickerModalElement extends UmbModalBaseElement< override render() { return html` - + ${this.#renderBody()} ${this.#renderBreadcrumb()}