Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-Mail subject rendered without context in E-mail admin list view #429

Closed
zagl opened this issue Nov 10, 2022 · 0 comments · Fixed by #430
Closed

E-Mail subject rendered without context in E-mail admin list view #429

zagl opened this issue Nov 10, 2022 · 0 comments · Fixed by #430

Comments

@zagl
Copy link
Contributor

zagl commented Nov 10, 2022

In the E-Mail admin list view the subject for pre-rendered emails is rendered again without context.
This is again a direct cause of #403 and similar to issue #421.

The fix would be the same. The check for instance.template in line 134 of admin.py should be replaced with instance.context.

def shortened_subject(self, instance):
if instance.template:
template_cache_key = '_subject_template_' + str(instance.template_id)

zagl pushed a commit to zagl/django-post_office that referenced this issue Nov 10, 2022
zagl pushed a commit to zagl/django-post_office that referenced this issue Nov 10, 2022
selwin pushed a commit that referenced this issue Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant