Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table column meanings in spec #267

Open
kengruven opened this issue Mar 15, 2023 · 4 comments
Open

Table column meanings in spec #267

kengruven opened this issue Mar 15, 2023 · 4 comments
Labels
todo Work needs to be completed

Comments

@kengruven
Copy link

In the spec, I'm seeing a few minor issues which aren't severe enough to prevent implementation but do make it slightly more confusing than need be:

  1. §29.2: "There are seven columns titled “name,” “print,” “c/s,” “c/i,” “M,” “value,” and “definition.”"
    The last two columns are actually titled "definition value" and "definition unit".
  2. §30.2: "There are seven columns titled “name,” “print,” “c/s,” “c/i,” “M,” “value,” and “definition.”"
    There are in fact 8 columns: "name", "kind of quantity", "print", "c/s", "c/i", "M", "definition value", and "definition unit".
  3. §44.2: "The meaning of the columns is declared in §34." §34.2: "The meaning of the columns is declared in §30.2."
    There's nothing technically wrong here but it is inconsistent. Several sections (like 43 and 47) refer to §30.2, while several others (like 36 and 37) refer to §34, which in turn says to look at §30.2. It would be nice if all of these pointed to the first section, instead of sometimes pointing to another reference.
  4. §49.2: "The meaning of the columns is declared in §49.2."
    This section consists in its entirety of a pointer to itself.
@gschadow
Copy link

gschadow commented May 2, 2023

The columns are described in each paragraph that introduces the table. The table under §29 is for dimensionless units and have no kind of quantity, so it is different.

Agree that in all of those places where it says "M," "value," and "definition" it should be changed everywhere to "M," "definition value," and "definition unit".

Agree that all references to §34.2 should instead go directly to §30.2.

In §44.2 the reference goes to §34, should also be §30.2

§49.2 should say:

There are five columns titled “name,” “print,” “c/s,” “c/i,” and “value.” The name is the full (official) name of the prefix. The symbol recommended for use in print is listed in the column “print.” “C/s,” and “c/i” list the symbol in the case sensitive and the case insensitive variants respectively. The value is the value by which the prefix-less unit atom would be multiplied to arrive at the value of the prefixed unit.

Also, §30.2 has a typo, the word "this" in "... use in print this is listed ..." should be deleted.


I would like to change the workflow status of this notice to "accepted" but I don't know where these workflow features are now since the migration to GitHub.

@timbrisc timbrisc added the todo Work needs to be completed label Jun 11, 2024
@timbrisc timbrisc added in process Work has been initiated and removed todo Work needs to be completed labels Jun 12, 2024
@timbrisc timbrisc removed the in process Work has been initiated label Jun 28, 2024
@timbrisc
Copy link
Member

Included in v2.2 release

@kengruven
Copy link
Author

The page https://ucum.org/ucum now says "Version: 2.2" and "Date: 2024-06-17" but all of the items listed by me (and agreed upon by @gschadow) are still present.

It's true that an extraneous word "this" was removed, but that was never really part of my issue.

@timbrisc
Copy link
Member

My apologies. This issue will be reopened and addressed as soon as possible.

@timbrisc timbrisc reopened this Jun 28, 2024
@timbrisc timbrisc added the todo Work needs to be completed label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo Work needs to be completed
Development

No branches or pull requests

3 participants