arrow cls tests #73
Merged
arrow cls tests #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivotron
requested changes
Sep 4, 2020
* make scripts/micro-osd.sh executable * remove repeated test execution logic (remove run_tests.sh; leave it inline) * remove build-rook-img step After the above the tests run but are throwing failures
Open
2 tasks
jlefevre
reviewed
Sep 10, 2020
jlefevre
reviewed
Sep 10, 2020
jlefevre
reviewed
Sep 10, 2020
jlefevre
reviewed
Sep 10, 2020
jlefevre
reviewed
Sep 10, 2020
jlefevre
reviewed
Sep 10, 2020
jlefevre
reviewed
Sep 10, 2020
5 tasks
ivotron
reviewed
Sep 11, 2020
src/CMakeLists.txt
Outdated
| @@ -1,10 +1,31 @@ | |||
| set(cls_dir ${CMAKE_INSTALL_LIBDIR}/rados-classes) | |||
|
|
|||
| # cls_sdk | |||
| add_library(cls_sdk SHARED cls_sdk.cc) | |||
| set_target_properties(cls_sdk PROPERTIES | |||
| add_library(cls_arrow_cls SHARED cls_sdk.cc) | |||
There was a problem hiding this comment.
since this is not the arrow class (yet), we could move it back to sdk, to avoid confusion
jlefevre
reviewed
Sep 11, 2020
.popper.yml
Outdated
| runs: [bash, -euxc] | ||
| args: | ||
| - | | ||
| cp build/lib/libcls_arrow_cls.so* /usr/lib64/rados-classes/ |
jlefevre
reviewed
Sep 11, 2020
scripts/micro-osd.sh
Outdated
| osd journal = ${OSD_DATA}.journal | ||
| osd journal size = 100 | ||
| osd objectstore = memstore | ||
| osd class load list = lock log numops refcount replica_log statelog timeindex user version arrow_cls |
jlefevre
reviewed
Sep 11, 2020
src/CMakeLists.txt
Outdated
| add_library(cls_sdk SHARED cls_sdk.cc) | ||
| set_target_properties(cls_sdk PROPERTIES | ||
| add_library(cls_arrow_cls SHARED cls_sdk.cc) | ||
| set_target_properties(cls_arrow_cls PROPERTIES |
jlefevre
reviewed
Sep 11, 2020
src/CMakeLists.txt
Outdated
| CXX_VISIBILITY_PRESET hidden | ||
| ) | ||
|
|
||
| install(TARGETS cls_arrow_cls DESTINATION ${cls_dir}) |
jlefevre
reviewed
Sep 11, 2020
src/cls_sdk.cc
Outdated
| CLS_VER(1,0) | ||
| CLS_NAME(sdk) | ||
| CLS_VER(1, 0) | ||
| CLS_NAME(arrow_cls) |
jlefevre
reviewed
Sep 11, 2020
src/cls_sdk.cc
Outdated
|
|
||
| cls_register("sdk", &h_class); | ||
| cls_register("arrow_cls", &h_class); |
jlefevre
reviewed
Sep 11, 2020
src/cls_sdk_test.cc
Outdated
| cluster.ioctx_create(pool_name.c_str(), ioctx); | ||
|
|
||
| bufferlist in, out; | ||
| ASSERT_EQ(0, ioctx.exec("test_object", "arrow_cls", "test_coverage_write", in, out)); |
jlefevre
reviewed
Sep 11, 2020
src/cls_sdk_test.cc
Outdated
| cluster.ioctx_create(pool_name.c_str(), ioctx); | ||
|
|
||
| bufferlist in, out; | ||
| ASSERT_EQ(0, ioctx.exec("test_object", "arrow_cls", "test_coverage_write", in, out)); |
jlefevre
reviewed
Sep 11, 2020
ivotron
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we need to create popper step for tests.