Skip to content
This repository has been archived by the owner on May 12, 2020. It is now read-only.

If no validated models exist, RAVE should either fail with a descriptive error message or generate an empty implementation #9

Open
ZacSweers opened this issue Feb 12, 2017 · 6 comments
Labels
Milestone

Comments

@ZacSweers
Copy link
Contributor

ZacSweers commented Feb 12, 2017

Otherwise compilation just fails saying it can't find the generated RAVE file without any real context.

CC @LukeStClair @behroozkhorashadi

@ZacSweers
Copy link
Contributor Author

FWIW, my vote is a warning + empty container. We can tack on an extra interface "isEmpty" or something to tell the upstream validator to skip it. We have cases where we generate models and don't actually know if there won't be non-validating models in them

@tonycosentini
Copy link
Contributor

I just ran into this in a new project, would be great to just generate an empty one - it took quite some time to figure this out.

@naturalwarren
Copy link
Contributor

I can look into this. @tonycosentini @behroozkhorashadi feel free to mark me as the assignee.

@ZacSweers
Copy link
Contributor Author

@naturalwarren no one can assign you because you're not in the uber org

@naturalwarren naturalwarren self-assigned this Apr 18, 2017
@naturalwarren naturalwarren added this to the RAVE 2 milestone Apr 18, 2017
@naturalwarren
Copy link
Contributor

Punting this for now.

@naturalwarren naturalwarren removed this from the RAVE 2 milestone May 8, 2017
@naturalwarren
Copy link
Contributor

Will move this discussion to #39

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants