Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling JavaConversions together with FlatPackage breaks compilation #41

Open
timo-schmid opened this issue Nov 4, 2018 · 2 comments

Comments

@timo-schmid
Copy link

See title:

This works:

scalapbCodeGeneratorOptions ++= Seq(FlatPackage)

This doesn't:

scalapbCodeGeneratorOptions ++= Seq(FlatPackage , JavaConversions)

Note: I'm using features such as oneof, so it might be a special case. Let me know if you need more information to reproduce this. I'll also look into it when I have a bit more spare time.

@fiadliel
Copy link
Contributor

fiadliel commented Nov 5, 2018

Thanks for the report, I'll look into it.

@fiadliel
Copy link
Contributor

fiadliel commented Nov 5, 2018

I have issues with compiling JavaConversions, no matter what the setting for FlatPackage. Code is getting the package name wrong for the Java class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants