From be7dab9c789b14052f1d9b9e1d4bf5287c76be32 Mon Sep 17 00:00:00 2001 From: Markus Schmidl Date: Mon, 9 Dec 2024 18:03:41 +0100 Subject: [PATCH] remove FIRESTARTER_THREAD_AFFINITY flag from cmake. update CHANGELOG and README. --- CHANGELOG | 5 ++++- README.md | 1 - cmake/BuildOptions.cmake | 6 ------ cmake/BuildSettings.cmake | 4 ---- 4 files changed, 4 insertions(+), 12 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index e99a5438..4cbdbf55 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -21,11 +21,14 @@ $$ TODO $$ TODO Version 2.x $$ TODO - add results verification -$$ TODO - add AMD GPUs $$ TODO - add more processors $$ TODO - support for AArch64 (64 Bit ARM) $$ TODO - support Infiniband interconnects $$ TODO +$$ TODO Version 2.2 +$$ TODO - added support for AMD GPUs +$$ TODO - support for thread binding on all supported platforms +$$ TODO - bug fixes related to thread binding with cgroups Version 2.1.1 - Removed MacOS 11 diff --git a/README.md b/README.md index 058af152..2de80d3c 100644 --- a/README.md +++ b/README.md @@ -150,7 +150,6 @@ CMake option | Description `FIRESTARTER_BUILD_TYPE` | Can be any of `FIRESTARTER`, `FIRESTARTER_CUDA`, `FIRESTARTER_ONEAPI`, or `FIRESTARTER_HIP`. Default `FIRESTARTER` `FIRESTARTER_LINK_STATIC` | Link FIRESTARTER as a static binary. Note, dlopen is not supported in static binaries. This option is not available on macOS or with CUDA or OneAPI enabled. Default `ON` `FIRESTARTER_BUILD_HWLOC` | Build hwloc dependency. Default `ON` -`FIRESTARTER_THREAD_AFFINITY` | Enable FIRESTARTER to set affinity to hardware threads. Default `ON` When building `FIRESTARTER_ONEAPI` make sure that the Intel Math Kernel Library (MKL) and the compiler `icx` and `icpx` can be found. Please provide diff --git a/cmake/BuildOptions.cmake b/cmake/BuildOptions.cmake index 660373ea..3673066a 100644 --- a/cmake/BuildOptions.cmake +++ b/cmake/BuildOptions.cmake @@ -14,12 +14,6 @@ endif() option(FIRESTARTER_BUILD_HWLOC "Build hwloc dependency." ON) -# Use of thread affinity is enabled on linux per default. -if(${CMAKE_SYSTEM_NAME} STREQUAL "Linux") - set(FIRESTARTER_THREAD_AFFINITY "Enable FIRESTARTER to set affinity to hardware threads." ON) -endif() - - # Debug feature are enabled on linux per default. if(${CMAKE_SYSTEM_NAME} STREQUAL "Linux") set(FIRESTARTER_DEBUG_FEATURES "Enable debug features" ON) diff --git a/cmake/BuildSettings.cmake b/cmake/BuildSettings.cmake index d16949ff..662c538c 100644 --- a/cmake/BuildSettings.cmake +++ b/cmake/BuildSettings.cmake @@ -7,10 +7,6 @@ if (FIRESTARTER_DEBUG_FEATURES) SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DFIRESTARTER_DEBUG_FEATURES") endif() -if (FIRESTARTER_THREAD_AFFINITY) - SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DFIRESTARTER_THREAD_AFFINITY") -endif() - # Not MSVC if(NOT "${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")