Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Deployment use secretRef even when embedded PostgreSQL is enabled #195

Open
Donnie opened this issue Nov 22, 2024 · 1 comment
Open

Comments

@Donnie
Copy link

Donnie commented Nov 22, 2024

{{- if .Values.postgresql.enabled }}

It would be great if we could use the config.postgresql.passwordSecretName secretref even when we use the embedded postgres.

The way it is now, any small change to the helm file triggers regeneration of the random password, and everything breaks.

Or one has to hardcode the secret into the helm values file.

@Donnie Donnie changed the title Make embedded Postgres take password from a secretref Let Deployment use secretRef even when embedded PostgreSQL is enabled Nov 22, 2024
@jjlgao
Copy link
Contributor

jjlgao commented Jan 22, 2025

Hi Donnie,

Apologies for the late response here. I'm not sure I fully understand, are you looking for the config.postgresql.passwordSecretName param to override the name part of the config if it's provided? Is this because the template command forces regeneration whenever it has to be rerun, even if the actual name of the secret doesn't ultimately change? Apologies, I haven't seen this happen, so I'm not familiar with the behavior you're mentioning.

          {{- if  .Values.postgresql.enabled }}
                name: {{ template "retool.postgresql.fullname" . }}

Can take care of the change once I make sure I understand what the ask is.

Thanks,
Jason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants