-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove validation of optional service
properties
#335
Comments
A month ago or so spec allowed only for "MUST" properties and @troyronda wanted to include additional properties only if they are on 'allowed' list. @troyronda Do you still want a check for properties added in add-service-endpoint patch or I should I remove check as @llorllale suggested? |
@troyronda any decisions on my comment above |
@sandrask @troyronda checks for specific fields outside those absolutely required by did-core ( |
@llorllale I agree that removing restrictions is more flexible so I am for it @troyronda just has to confirm it is ok to remove allowed list (since it was his idea to create it) |
After discussion with @llorllale and @troyronda it has been decided to disable validation of optional service endpoint fields. New issue has been created #373 |
Remove validation of optional service properties Closes trustbloc#335 Signed-off-by: Sandra Vrtikapa <[email protected]>
Remove validation of optional service properties Closes trustbloc#335 Signed-off-by: Sandra Vrtikapa <[email protected]>
Remove validation of optional service properties Closes trustbloc#335 Signed-off-by: Sandra Vrtikapa <[email protected]>
The sidetree spec mandates the inclusion of
id
,type
, andendpoint
in eachservice
entry: https://identity.foundation/sidetree/spec/#add-service-endpoints.Beyond those, it does not prescribe any limitation on additional fields that may be included. This check should therefore be removed.
The text was updated successfully, but these errors were encountered: