Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export all Props interfaces #2667

Closed
RobKohr opened this issue Nov 20, 2023 · 1 comment
Closed

Export all Props interfaces #2667

RobKohr opened this issue Nov 20, 2023 · 1 comment
Labels
type: feature New feature or request

Comments

@RobKohr
Copy link

RobKohr commented Nov 20, 2023

Does your feature request relate to a specific USWDS component?

All components

What USWDS Version is this feature present in?

Current

Is your feature request related to a problem? Please describe.

I would like to create wrappers for react-uswds components to add functionality to my own project. It would make it easier if I can import the props definitions for components and extend them.

Describe the solution you'd like

add export before all Prop type interfaces

Describe alternatives you've considered

I have done copy/pasting interfaces in my own project, but that doesn't seem like a good maintainable solution.

Additional context
Created PR 2666 for this

@brandonlenz
Copy link
Contributor

brandonlenz commented Dec 4, 2023

Thanks for the issue and PR! Closing this issue as this is a duplicate of #2587, where #2587 provides a little more guidance on the desired approach.

If you have the time to update your PR with the considerations noted in the existing issue, that would be lovely!

@brandonlenz brandonlenz closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants