-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow underscores in URLs (Diff in comments, can I have permissions to push a feature branch to make a PR with?) #129
Comments
It might take me a few days to squeeze free, but two regex and what will be
some discussion around unit tests was much simpler than I was expecting.
…On Thu, Jan 6, 2022, 11:12 PM itsojon ***@***.***> wrote:
hey @meyerkev <https://github.com/meyerkev>! you'd update the regex for
the frontend here
<https://github.com/trotto/go-links/blob/7b22f7437024ced5622508c311821d8b014ba0f6/frontend/src/actions.js#L43>
and for the server here
<https://github.com/trotto/go-links/blob/1fec137a64f028d6b77560c8ff2b355e3e4130e6/server/src/modules/links/helpers.py#L148>.
currently go link keyword are restricted to letter, numbers, and hyphens
(e.g., go/project-template).
—
Reply to this email directly, view it on GitHub
<#129 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADEUGREOV7SXYQGCGWSKFDUUZR4HANCNFSM5LNOW4HQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
So I currently lack permission to push a branch to trotto/go-links.git, so I linked the diff and I'm not sure how to request those permissions. I might also add some documentation around how to run webpack because that was by far the longest part of this.
|
meyerkev
changed the title
What would it take to allow underscores in URLs?
Allow underscores in URLs
Jan 7, 2022
meyerkev
changed the title
Allow underscores in URLs
Allow underscores in URLs (Diff in comments, can I have permissions to push a feature branch to make a PR with?)
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
so instead of go/projecttemplate, have go/project_template?
The https://trot.to/#/ link generator strips underscores when making links.
The text was updated successfully, but these errors were encountered: