Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table manualPaginationOptions set to 'null' #3027

Open
2 tasks done
kuhnboy opened this issue Nov 25, 2024 · 1 comment
Open
2 tasks done

Table manualPaginationOptions set to 'null' #3027

kuhnboy opened this issue Nov 25, 2024 · 1 comment
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble

Comments

@kuhnboy
Copy link

kuhnboy commented Nov 25, 2024

Prerequisites

Describe the issue

I have some initialization code on a table where I am setting manualPaginationOptions to null. Based upon timing this can fire the 'onManualPaginationOptionsChange' event. When this is handled, there is not a null check on the 'newVal' object and then fails to render. There may be a few other watched events that could cause the same behavior.

onManualPaginationOptionsChange(newVal) {
        var _a, _b, _c, _d, _e;
        if (Object.keys(newVal).length === 0) {
            (_a = this.tableCore) === null || _a === void 0 ? void 0 : _a.setOptions('manualPagination', false);
            (_b = this.tableCore) === null || _b === void 0 ? void 0 : _b.setState('pagination', {
                pageIndex: 0,
                pageSize: this.pageSizeList[0],
            });
        }
        else {
            (_c = this.tableCore) === null || _c === void 0 ? void 0 : _c.setOptions('pageCount', newVal.pageCount);
            (_d = this.tableCore) === null || _d === void 0 ? void 0 : _d.setOptions('manualPagination', true);
            (_e = this.tableCore) === null || _e === void 0 ? void 0 : _e.setState('pagination', {
                pageIndex: newVal.currentPageIndex - 1,
                pageSize: newVal.currentPageSize,
            });
        }
    }

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

No response

What browser(s) are you seeing the problem on?

No response

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

0.41.1

Priority

Medium

What product/project are you using Modus Components for ?

Trimble Unity

What is your team/division name ?

O&PS

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response

@kuhnboy kuhnboy added the bug Something is wrong and needs to be addressed label Nov 25, 2024
@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Nov 25, 2024
Copy link

Hello @kuhnboy! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble
Projects
Status: In Review
Development

No branches or pull requests

1 participant