Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table method getEditableCell unclear #2990

Open
2 tasks done
kuhnboy opened this issue Nov 18, 2024 · 1 comment
Open
2 tasks done

Table method getEditableCell unclear #2990

kuhnboy opened this issue Nov 18, 2024 · 1 comment
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble

Comments

@kuhnboy
Copy link

kuhnboy commented Nov 18, 2024

Prerequisites

Describe the issue

In the storybook documentation, getEditableCell description is:

Handle the editability of a specific cell.

It appears after searching I was able to find the intent of the method: #2541

The documentation needs to be improved (or method name changed) to be more clear such as:
"Put the cell in edit mode".

If I look at the code, the comment is even more confusing for 'getEditableCell':

/**
   * Returns whether a cell is editable based on row index and column ID.
   * @param rowIndex The index of the row.
   * @param columnId The ID of the column.
   * @returns Boolean indicating if the cell is editable.
   */

But the function has no return value:

async getEditableCell(rowIndex: string, columnId: string): Promise<void> {
...
    await cellToEdit.handleCellEdit(rowIndex, columnId);
  }

I suggest there be a better name for this method like: 'editCell' as 'get' is inappropriate as its not getting anything.

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

No response

What browser(s) are you seeing the problem on?

No response

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

0.41.1

Priority

Low

What product/project are you using Modus Components for ?

Trimble Unity

What is your team/division name ?

O&PS

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response

@kuhnboy kuhnboy added the bug Something is wrong and needs to be addressed label Nov 18, 2024
Copy link

Hello @kuhnboy! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble
Projects
Status: In Review
Development

No branches or pull requests

1 participant