Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree View With Item Action Bar Not Rendering As Expected. #2219

Closed
2 tasks done
kuhnboy opened this issue Feb 27, 2024 · 3 comments
Closed
2 tasks done

Tree View With Item Action Bar Not Rendering As Expected. #2219

kuhnboy opened this issue Feb 27, 2024 · 3 comments
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble

Comments

@kuhnboy
Copy link

kuhnboy commented Feb 27, 2024

Prerequisites

Describe the issue

I am having an issue running an example that shows an item with action bar:

image

With the same exact code, I am rendering this:

image

Expectation: Icons should render.

Sample Code:

<div>
        <modus-tree-view style="width:400px;" checkbox-selection="false" checked-items="false" expanded-items="false"
            multi-checkbox-selection="false" multi-selection="false" selected-items="false" size="" class="hydrated">
            <modus-tree-view-item node-id="1" label="Inbox" class="hydrated"></modus-tree-view-item>
        </modus-tree-view>
    </div>
    <script>
        function loadActions() {
            document.querySelector('[node-id="1"]').actions = [
                { id: 'export', icon: 'export', label: 'Export' },
                { id: 'history', icon: 'history', label: 'History' },
                { id: 'edit', icon: 'pencil', label: 'Edit' },
            ];
        }
        loadActions();
    </script>

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Microsoft Edge

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

0.16.0

Priority

Medium

What product/project are you using Modus Components for ?

ModusBlazor

What is your team/division name ?

AECO

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response

@kuhnboy kuhnboy added the bug Something is wrong and needs to be addressed label Feb 27, 2024
Copy link

Hello @kuhnboy! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Feb 27, 2024
@cjwinsor
Copy link
Contributor

@kuhnboy Action items were added to the content tree in version 17. I see on your ticket you are using version 16. Can you verify on latest version?
https://codepen.io/cjwinsor/pen/xxeKPrW

@kuhnboy
Copy link
Author

kuhnboy commented Feb 29, 2024

You're right. Sorry about that!.

@kuhnboy kuhnboy closed this as completed Feb 29, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Modus Web Components Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble
Projects
Archived in project
Development

No branches or pull requests

2 participants