Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slider Emits String Instead of Number #2198

Open
2 tasks done
kuhnboy opened this issue Feb 23, 2024 · 1 comment
Open
2 tasks done

Slider Emits String Instead of Number #2198

kuhnboy opened this issue Feb 23, 2024 · 1 comment
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble

Comments

@kuhnboy
Copy link

kuhnboy commented Feb 23, 2024

Prerequisites

Describe the issue

A modus slider (even though the value, max, and min are all numeric) emits a string on the valueChange event.

Example:

<body>
    <modus-slider label="Slider"></modus-slider>

    <script>
    const modusSlider = document.querySelector('modus-slider');
    modusSlider.addEventListener('valueChange', (evt) => {
        alert(typeof evt.detail);
    });
    </script>
</body>

I would expect the event detail to be a number.

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Microsoft Edge

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

0.16.0

Priority

Medium

What product/project are you using Modus Components for ?

ModusBlazor

What is your team/division name ?

AECO

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response
@kuhnboy kuhnboy added the bug Something is wrong and needs to be addressed label Feb 23, 2024
@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Feb 23, 2024
@github-actions GitHub Actions
Copy link

Hello @kuhnboy! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble
Projects
Modus Web Components
Status: In Review
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kuhnboy