Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pull Request Template #2173

Open
coliff opened this issue Feb 19, 2024 · 0 comments
Open

Update Pull Request Template #2173

coliff opened this issue Feb 19, 2024 · 0 comments
Assignees
@prashanth-offcl
Labels
devOps Site management, GitHub workflows, etc

Comments

@coliff
Copy link
Member

coliff commented Feb 19, 2024

The Pull Request template could do with some updates.

  • Perhaps we should say the checklist marks are mandatory (if applicable) ?
  • Specifically mention that should run npm run lint & npm run test ?
  • Mention about the Pull Request title format ("Name of Component: What was fixed" - e.g. "Modal: Fixed vertical positioning") ?
@coliff coliff added the devOps Site management, GitHub workflows, etc label Feb 19, 2024
@coliff coliff removed the status in Modus Web Components Oct 3, 2024
@prashanth-offcl prashanth-offcl self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prashanth-offcl prashanth-offcl

Labels
devOps Site management, GitHub workflows, etc
Projects
Modus Web Components
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cjwinsor @coliff @prashanth-offcl