Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: Small buttons are not sized correctly #2162

Closed
coliff opened this issue Feb 16, 2024 · 7 comments · Fixed by #2975
Closed

Button: Small buttons are not sized correctly #2162

coliff opened this issue Feb 16, 2024 · 7 comments · Fixed by #2975
Assignees
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble priority:high Prioritization for this item is high

Comments

@coliff
Copy link
Member

coliff commented Feb 16, 2024

See screenshot (from https://modus-web-components.trimble.com/?path=/docs/components-content-tree--multi-selection) showing active state here:

image

We should specify height and width of the button, or set consistent vertical/horizontal padding to fix this issue.

@coliff coliff added the bug Something is wrong and needs to be addressed label Feb 16, 2024
@cjwinsor cjwinsor changed the title Content Tree: Custom Action Bar buttons are not sized correctly Button: Small buttons are not sized correctly Apr 3, 2024
@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Apr 3, 2024
@cjwinsor
Copy link
Contributor

cjwinsor commented Apr 3, 2024

The actionbar is just a collection of modus buttons so the issue should be addressed on small buttons. Ensure size and focus borders are correct after fix.

@enowak1031 enowak1031 added the priority:high Prioritization for this item is high label Nov 6, 2024
@enowak1031 enowak1031 moved this from In Review to To Do in Modus Web Components Nov 6, 2024
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu self-assigned this Nov 7, 2024
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu moved this from To Do to In Progress in Modus Web Components Nov 7, 2024
@coliff
Copy link
Member Author

coliff commented Nov 8, 2024

@ElishaSamPeterPrabhu Maybe the modus-button should have icon-only on it e.g. icon-only="add" ?

@ElishaSamPeterPrabhu
Copy link
Collaborator

@ElishaSamPeterPrabhu Maybe the modus-button should have icon-only on it e.g. icon-only="add" ?

Yes we can do that but the icon map doesn't contain for the other icons

So where should we update them?

@coliff
Copy link
Member Author

coliff commented Nov 8, 2024

...or instead use some custom CSS like:

height: 28px; width: 28px; padding: 8px; margin-left: 8px

@ElishaSamPeterPrabhu
Copy link
Collaborator

height: 28px; width: 28px; padding: 8px; margin-left: 8px

after applying the css
image
Is this the expected look?

@coliff
Copy link
Member Author

coliff commented Nov 11, 2024

Is this the expected look?

not exactly, I just included that CSS as a starting point which improves things somewhat.

@ElishaSamPeterPrabhu
Copy link
Collaborator

Is this the expected look?

not exactly, I just included that CSS as a starting point which improves things somewhat.

@coliff
There are two points to address

  1. Content Tree - Custom Action Bar is invisible in dark theme #1466 has a similar need to decide between modus button with icon-only property or the custom css with svg.
  2. Is there a reference on how the custom bar should look as its not available in figma?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble priority:high Prioritization for this item is high
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants