Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert: Close button accessibility issues #2082

Closed
2 tasks done
coliff opened this issue Jan 29, 2024 · 0 comments · Fixed by #2083
Closed
2 tasks done

Alert: Close button accessibility issues #2082

coliff opened this issue Jan 29, 2024 · 0 comments · Fixed by #2083
Assignees
Labels
2 2 story points accessibility bug Something is wrong and needs to be addressed

Comments

@coliff
Copy link
Member

coliff commented Jan 29, 2024

Prerequisites

Describe the issue

Tabbing to the close button of an alert is simply announced as 'clickable'. There is no text, aria-label and there is no role defined.

To fix the issue the icon-close-container div should have aria-label="Dismiss alert" and role="button".

Reduced test cases

I tested this URL: https://modus-web-components.trimble.com/?path=/docs/components-alert--default with NVDA on Windows 11.

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Microsoft Edge

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

v.0.13.0

Priority

Medium

What product/project are you using Modus Components for ?

Modus

What is your team/division name ?

Modus

Are you willing to contribute ?

Yes

Are you using Modus Web Components in production ?

https://modus-web-components.trimble.com/

@coliff coliff added the bug Something is wrong and needs to be addressed label Jan 29, 2024
@coliff coliff self-assigned this Jan 29, 2024
@coliff coliff added 2 2 story points accessibility labels Jan 29, 2024
@coliff coliff linked a pull request Jan 29, 2024 that will close this issue
13 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Modus Web Components Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 2 story points accessibility bug Something is wrong and needs to be addressed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant