Modus Icon: Event Name is iconClick, not onClick as shown in Storybook and clicking causes error

[cjwinsor]

Prerequisites

• I have searched for duplicate or closed issues
• I have read the contributing guidelines

Describe the issue

Component creates iconClick event

  @Event() iconClick?: EventEmitter;

But Storybook shows it has having an onClick event that is emitted

And when the icon is clicked it produces an error

Uncaught TypeError: Cannot read properties of undefined (reading 'emit')
    at Object.onClick (25.cf0f1bcf.iframe.bundle.js:1:2565)
    at IconSun.Object.onClick (0.fb127b46.iframe.bundle.js:1:421530)

This is caused by the icons onClick being set as

<IconMap ... onClick={this.onClick} ... />

when it should be this at minimum to maintain the this context.

<IconMap ... onClick={() => this.onClick()} ... />

Otherwise the context will be the icon from the icon map, not the modus-icon.

I am creating this ticket so I can work on it later.

Reduced test cases

In Storybook for MWC, navigate to the Icon component and click on the icon. Observer the javascript error in the dev console.

What operating system(s) are you seeing the problem on?

No response

What browser(s) are you seeing the problem on?

No response

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

v0.13.0

Priority

Medium

What product/project are you using Modus Components for ?

Modus

What is your team/division name ?

Modus

Are you willing to contribute ?

Maybe

Are you using Modus Web Components in production ?

No response

[ElishaSamPeterPrabhu]

Closing this issue as it is fixed in #2201