Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete input should be type="search" #2044

Closed
2 tasks done
coliff opened this issue Jan 18, 2024 · 0 comments · Fixed by #2061
Closed
2 tasks done

Autocomplete input should be type="search" #2044

coliff opened this issue Jan 18, 2024 · 0 comments · Fixed by #2061
Assignees
@coliff
Labels
1 1 story point accessibility bug Something is wrong and needs to be addressed

Comments

@coliff
Copy link
Member

coliff commented Jan 18, 2024 •
edited
Loading

Prerequisites

Describe the issue

Entering text in Autocomplete and pressing Escape should clear the input as any default type="search" text would. If the input was type=search and not type=text then this would work as expected.

This requires: #524

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Microsoft Edge

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

v.0.12.0

Priority

Medium

What product/project are you using Modus Components for ?

Modus

What is your team/division name ?

Modus

Are you willing to contribute ?

Maybe

Are you using Modus Web Components in production ?

https://modus-web-components.trimble.com/
@coliff coliff added the bug Something is wrong and needs to be addressed label Jan 18, 2024
@coliff coliff moved this from In Review to To Do in Modus Web Components Jan 22, 2024
@coliff coliff self-assigned this Jan 22, 2024
@coliff coliff moved this from To Do to In Progress in Modus Web Components Jan 24, 2024
@coliff coliff added the 1 1 story point label Jan 24, 2024
@coliff coliff linked a pull request Jan 24, 2024 that will close this issue
Autocomplete: Use input type="search" #2061
Merged
13 tasks
@coliff coliff mentioned this issue Jan 24, 2024
Merged
13 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Modus Web Components Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coliff coliff

Labels
1 1 story point accessibility bug Something is wrong and needs to be addressed
Projects
Modus Web Components
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Autocomplete: Use input type="search" trimble-oss/modus-web-components
2 participants
@coliff @rthanga1