Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Angular version 17 for @trimble-oss/modus-angular-components #2002

Closed
2 tasks done
quynh-le-trimble opened this issue Jan 10, 2024 · 5 comments · Fixed by #2208
Closed
2 tasks done

Build Angular version 17 for @trimble-oss/modus-angular-components #2002

quynh-le-trimble opened this issue Jan 10, 2024 · 5 comments · Fixed by #2208
Assignees
Labels
external-request Bugs and features reported by individuals from other teams in Trimble

Comments

@quynh-le-trimble
Copy link
Contributor

Prerequisites

Proposal

Build Angular version 17 for @trimble-oss/modus-angular-components

Motivation and context

For Angular project v17+

What is the issue regarding ?

@trimble-oss/modus-angular-components

Priority

High

What product/project are you using Modus Components for ?

Prism

What is your team/division name ?

Prism

Are you willing to contribute ?

Yes

Are you using Modus Web Components in production ?

No

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Jan 10, 2024
Copy link

Hello @quynh-le-trimble! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@coliff
Copy link
Member

coliff commented Jan 16, 2024

Hey there @quynh-le-trimble - it'd be great if you wanted to take this on! Let me know if you have any questions about it.

@coliff coliff moved this from In Review to To Do in Modus Web Components Jan 29, 2024
@quynh-le-trimble
Copy link
Contributor Author

@coliff Sure, is there any documentation available where i can get these changes updated and published?

@coliff
Copy link
Member

coliff commented Feb 22, 2024

Hello! I added the 'angular-16' workspace to Modus Web Components a while back and these were the equivalent steps I took to do that.

  • Made of a copy of the modus-web-components\angular-workspace\ng16 folder and name it ng17.
  • In the package.json in that folder, update engines (node) to >=18.13.0
  • Read through the upgrade guide and follow the steps: https://update.angular.io/?v=16.0-17.0
  • In the root package.json there are steps to build-angular - will need to && cd ../ng17 && npm ci && npm run build to the end
  • Make a PR with the above changes and we'll get it merged and published! :-)

@quynh-le-trimble
Copy link
Contributor Author

Thanks, @coliff! I pushed a PR with the changes you requested. Please let me know if any issues come up.

@coliff coliff mentioned this issue Feb 27, 2024
13 tasks
@github-project-automation github-project-automation bot moved this from To Do to Done in Modus Web Components Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-request Bugs and features reported by individuals from other teams in Trimble
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants