Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace home-made types for dependency tween-functions with types from DefinitelyTyped #2

Open
anddoutoi opened this issue Mar 4, 2023 · 0 comments
Open

Replace home-made types for dependency tween-functions with types from DefinitelyTyped #2

anddoutoi opened this issue Mar 4, 2023 · 0 comments
Labels
good first issue Good for newcomers low hanging fruit Minimum effort

Comments

@anddoutoi
Copy link
Member

Issue

This package depends on tween-functions. Today the types for tween-functions are home-made and defined in ./types/tween-functions.d.ts.

These should be replace with the official types from DefinitelyTyped.

Suggestion

rpm install --save-dev @types/tween-functions, delete ./types/tween-functions.d.ts and update tsconfig.json.

Risks

  • An upgrade of typescript package might be needed. It might lead to an upgrade cascade of other packages. If that is the case this issue should be postponed and escalated within the team.
@anddoutoi anddoutoi added good first issue Good for newcomers low hanging fruit Minimum effort labels Mar 4, 2023
@anddoutoi anddoutoi changed the title Replace home-made types for dependency tween-functions with types from @types Replace home-made types for dependency tween-functions with types from DefinitelyTyped Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers low hanging fruit Minimum effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anddoutoi