Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web SSH key setting only accepts RSA keys #2720

Closed
sarahhodne opened this issue Aug 27, 2014 · 5 comments · May be fixed by travis-ci/travis-core#409
Closed

Web SSH key setting only accepts RSA keys #2720

sarahhodne opened this issue Aug 27, 2014 · 5 comments · May be fixed by travis-ci/travis-core#409

Comments

@sarahhodne
Copy link
Contributor

We should also allow DSA keys to be set, since GitHub allows for those as well. I think all that is needed for this is to somehow add this to the validation logic on the API.

@drogus
Copy link
Contributor

drogus commented Aug 28, 2014

Do you know if any other types of keys are accepted?

@sarahhodne
Copy link
Contributor Author

Now that you mention it, I think they support ecdsa too. It you try to enter an invalid key on the website, it'll list the allowed types.

On Aug 28, 2014, at 15:18, Piotr Sarnacki [email protected] wrote:

Do you know if any other types of keys are accepted?


Reply to this email directly or view it on GitHub.

@sarahhodne
Copy link
Contributor Author

'ssh-rsa', 'ssh-dss', 'ecdsa-sha2-nistp256', 'ecdsa-sha2-nistp384', or 'ecdsa-sha2-nistp521'

@grooverdan
Copy link

for addon: ssh_known_hosts travis-ci/travis-build/pull/485

@stale
Copy link

stale bot commented Apr 14, 2018

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues

@stale stale bot added the stale label Apr 14, 2018
@stale stale bot closed this as completed Apr 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants