Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect pruning condition in multiple implementations #33

Open
BogdanArdelean opened this issue Mar 25, 2019 · 0 comments
Open

Incorrect pruning condition in multiple implementations #33

BogdanArdelean opened this issue Mar 25, 2019 · 0 comments

Comments

@BogdanArdelean
Copy link

In many implementations the pruning condition is
if connection.arrivalTime > earliestArrivalTime then break loop
This is incorrect since we can't make assumptions on arrival times.

The correct pruning condition is
if connection.departureTime >= earliestArrivalTime then break loop

Pull request that addresses the issue: #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BogdanArdelean