-
Notifications
You must be signed in to change notification settings - Fork 24
remove persistentHeader and persistentFooter #16
Comments
@torbenkeller what if the height of the header is unknown (or yet to be calculated)? How do we expect users of the API to deal with this? |
@alestiago I don't think the header height will ever be unknown. Either the user knows it directly because the header is a |
@torbenkeller I don't think we should be forcing the user to pre-calculate the size of the header by looking at the insets and children of the header. I think this because:
Can we avoid forcing the user to pre-calculate the size? |
@alestiago I think you are right. The header should stay and then I can update the docs and explain how to use it the best way. But the footer is totally unnecessary in my opinion, so I will remove it. |
That sounds great! Indeed the footer seems unnecessary. I don't know if we can provide any feature that can make implementing the footer easier without constraining the developer. A possible edge scenario I can think of is when an Android device has the navigation bar (the one with three icons) enabled and it is transparent. But don't know if this would be an issue; since it can be worked around with existing widgets. |
The
persistentHeader
andpersistentFooter
fields are unnecessary.persistentFooter
can be implemented around theExpandableBottomSheet
persistentHeader
should be part of theexpandableContent
and then you set thepersistentContentSize
to the height of the headerThe text was updated successfully, but these errors were encountered: