Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$30]Inconsistent landmarks across pages. #3234

Closed
veshu opened this issue Aug 21, 2019 · 12 comments
Closed

[$30]Inconsistent landmarks across pages. #3234

veshu opened this issue Aug 21, 2019 · 12 comments

Comments

@veshu
Copy link
Contributor

veshu commented Aug 21, 2019

Describe the bug

Inconsistent landmarks across pages.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the sample challenge page
  2. Ensure that the screen reader is switched on.
  3. Press the letter 'r' a couple of times to navigate to the various landmarks on the page.
  4. Note that there is no 'banner' landmark for the header, 'main landmark' for the main content of the page, and 'contentinfo landmark' for the footer of the page.
  5. Also note that this issue can be found on the other pages too. The landmarks are inconsistent."

Expected behavior

The content on the page should be placed inside the relevant landmark roles for screen reader users to skip to the content in the respective landmark he/she intends to read. The banner landmark should contain the header of the page. The main landmark should be wrapped around the main content of the page. The contentinfo should be used to contain the footer of the page. Navigation, search etc can be used additionally.

Actual behavior

There are no banner, main and contentinfo landmarks on the page.

non-active and active login button do not comply with WCAG. Make it the same color scheme as registration page buttons "

Additional context

Type: Landmarks

Page: https://www.topcoder.com/challenges/30095347

Status: Partially fixed on a few pages. Correctly fixed on the sample challenge page.

@veshu veshu added P1 Urgent (resolve within 24 hours) Accessibility labels Aug 21, 2019
@veshu veshu changed the title Inconsistent landmarks across pages. [$30]Inconsistent landmarks across pages. Aug 21, 2019
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30099914 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30099914 has been updated - the new changes has been updated for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30099914 has been updated - it has been assigned to rohitgupta_.

This is an automated message for crazyk via Topcoder X

@r0hit-gupta
Copy link
Collaborator

@veshu can you please provide with the links where the landmarks are not present?

@veshu
Copy link
Contributor Author

veshu commented Aug 22, 2019

@r0hit-gupta https://www.w3.org/TR/WCAG20-TECHS/ARIA11.html this is the guidelines for this.

We need to separate the landmarks so user can outline the regions on challenge detail page.

Note: This behavior should also be fixed on other pages (listing, login/register, submit page)

@r0hit-gupta
Copy link
Collaborator

PRs at appirio-tech/accounts-app#303 & #3255

@tosha5252
Copy link

Also note that this issue can be found on the other pages too. The landmarks are inconsistent."

Status: Partially fixed on a few pages. Correctly fixed on the sample challenge page.

@sushilshinde what pages does this issue cover?

@tosha5252 tosha5252 added On hold Need clarification Need clarification to proceed fixing the issue further and removed On hold labels Sep 3, 2019
@veshu
Copy link
Contributor Author

veshu commented Sep 4, 2019

@tosha5252 Current scope pages are challenge listing, challenge detail and submit page,
Register page, login page.

@veshu veshu removed the Need clarification Need clarification to proceed fixing the issue further label Sep 4, 2019
@drasticdpk
Copy link
Collaborator

@r0hit-gupta Can we make this page consistent , since screen reader does not read NOT A MEMBER YET on login page but reads HAVE AN ACCOUNT on registration page.
Here is the reference :
image
image

@drasticdpk drasticdpk added the QA Fail QA verification on Dev has failed. Assignee to redo the fix. label Sep 6, 2019
@r0hit-gupta
Copy link
Collaborator

@drasticdpk PR at appirio-tech/accounts-app#311. This should fix it.

@crazyk07
Copy link

Closing ticket due to shift in priority, will not be able to complete but will still pay for effort rendered.

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30099914

This is an automated message for crazyk via Topcoder X

@crazyk07 crazyk07 added tcx_Paid Accessibility Incomplete and removed Accessibility Challenge Page P1 Urgent (resolve within 24 hours) QA Fail QA verification on Dev has failed. Assignee to redo the fix. tcx_ReadyForReview labels Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants