Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Sprache to Superpower #99

Closed
rogusdev opened this issue Jul 30, 2024 · 3 comments
Closed

Migrate from Sprache to Superpower #99

rogusdev opened this issue Jul 30, 2024 · 3 comments

Comments

@rogusdev
Copy link
Collaborator

https://github.com/datalust/superpower is apparently the replacement for sprache, by sprache's author, per sprache/Sprache#194 (comment) .

Hopefully switching to that would be easy, and also allow us to remove the extra deps that are only necessary to avoid snyk/checkmarx warnings per #68 .

@Philipp-Binder
Copy link
Contributor

Philipp-Binder commented Sep 28, 2024

In #106 I started from your first commit regarding superpower and worked on just exactly replacing Sprache as good as possible.

I think there is much space for Improvements by using the new concept of TokenParsers.
But that would be a huge make-over which also requires deep changes in the testing-project I guess.

If this direction is of interest to you, I'd dive into it after the replacement ist done.

@rogusdev
Copy link
Collaborator Author

rogusdev commented Oct 9, 2024

I am definitely open to using the newer superpower library more thoroughly. I am not in a rush to do anything more than make the migration myself, but I heartily support you reviewing things and making changes if it excites you :)

@rogusdev
Copy link
Collaborator Author

Resolved by #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants