Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefixed paths (ROOT_URL) is not considered on IE9 hash position #1

Open
mperkh opened this issue Feb 4, 2016 · 7 comments
Open

Prefixed paths (ROOT_URL) is not considered on IE9 hash position #1

mperkh opened this issue Feb 4, 2016 · 7 comments

Comments

@mperkh
Copy link

mperkh commented Feb 4, 2016

kadirahq/flow-router#496

@mperkh
Copy link
Author

mperkh commented Feb 4, 2016

I was able to fix the issue by changing settings.js to:

// Make sure that polyfilled links are redirected to correct links in 
// supporting browsers. Enables sharing links between IE and non-IE
// e.g. http://example.com/#/some-path -> http://example.com/some-path
var basePath = __meteor_runtime_config__.ROOT_URL_PATH_PREFIX || '';
history.redirect('/', basePath + '/');

@mgarf
Copy link

mgarf commented Mar 8, 2016

+1

@mgarf
Copy link

mgarf commented Mar 8, 2016

@mperkh - I forked out the package and added your change but still getting the pound (#) symbol issue. Is there any other changes that need to be made?

@mperkh
Copy link
Author

mperkh commented Mar 8, 2016

@mgarf Where can I see your fork? I will create a pull request. Perhaps @tomwasd will react to it..

@tomwasd
Copy link
Owner

tomwasd commented Mar 8, 2016

Hi guys,

I'm afraid I've dropped IE9 support for my own app now so all the IE9 tweaks I did to get FlowRouter working are on the back burner.

If I understand the issue I'd imagine @mperkh's fix would work nicely. If @mgarf is able to get it working too I'd happily accept a PR :)

@mgarf
Copy link

mgarf commented Mar 8, 2016

@mperkh see here: https://github.com/mgarf/historypollyfill My assumption is the only file that was edited was settings.js. The history.js is from another repository

mperkh added a commit to mperkh/history-polyfill that referenced this issue Mar 8, 2016
@mperkh
Copy link
Author

mperkh commented Mar 10, 2016

@mgarf Ok, Pull Request issued..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants