Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed edge anchor styling (#639) #642

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed edge anchor styling (#639) #642

wants to merge 2 commits into from

Conversation

AlexBxl
Copy link
Contributor

@AlexBxl AlexBxl commented Jan 17, 2025 •
edited by github-actions bot
Loading

User description

Description

  • fixed edge anchor styling

Fixes #639

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Video

b69fe841-468c-4228-bb2a-0cd781ce2400

PR Type

Bug fix

Description

  • Improved edge anchor styling for better emphasis.

  • Added padding, border, and shadow to PassthroughNode.

  • Included a changeset file for version tracking.

Changes walkthrough 📝

Relevant files
Enhancement
passthroughNode.tsx
Updated styling for `PassthroughNode` component                   

packages/graph-editor/src/components/flow/nodes/passthroughNode.tsx

  • Added padding to the PassthroughNode component.
  • Introduced a solid border for better visibility.
  • Applied shadow styling for enhanced emphasis.
    		• +3/-0     
    Documentation
    dull-buses-press.md
    Added changeset for edge anchor fix                                           

    .changeset/dull-buses-press.md

    • Added a changeset file documenting the edge anchor fix.
    		 +5/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @changeset-bot changeset-bot
    Copy link

    changeset-bot bot commented Jan 17, 2025 •
    edited
    Loading

    🦋 Changeset detected

    Latest commit: 764deaf

    The changes in this PR will be included in the next version bump.

    This PR includes changesets to release 1 package
    Name Type
    @tokens-studio/graph-editor Patch

    Not sure what this means? Click here to learn what changesets are.

    Click here if you're a maintainer who wants to add another changeset to this PR

    @github-actions GitHub Actions
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ✅

    639 - Fully compliant

    Fully compliant requirements:

    • Improve edge anchor styling for better emphasis.
    • Add padding, border, and shadow to PassthroughNode.
    • Include a changeset file for version tracking.

    Not compliant requirements:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Styling Consistency

    Ensure that the added padding, border, and shadow styling for PassthroughNode aligns with the overall design system and does not introduce visual inconsistencies.

    padding: 'var(--size-50)',
border: '2px solid var(--colors-nodeBorder)',
boxShadow: 'var(--shadows-contextMenu)',

    @github-actions GitHub Actions
    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Add a fallback value for the boxShadow property to ensure robustness if the CSS variable is undefined

    Ensure that the CSS variable --shadows-contextMenu is defined and valid to prevent
    potential rendering issues or unexpected behavior.

    packages/graph-editor/src/components/flow/nodes/passthroughNode.tsx [30]

    -boxShadow: 'var(--shadows-contextMenu)',
+boxShadow: 'var(--shadows-contextMenu, none)',
    Suggestion importance[1-10]: 8

    Why: Adding a fallback value for the boxShadow property improves robustness and prevents potential rendering issues if the CSS variable --shadows-contextMenu is undefined. This is a practical enhancement to ensure consistent behavior across different environments or themes.

    		8

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @mck mck mck approved these changes

    Assignees
    No one assigned
    Labels
    Review effort [1-5]: 2
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    add emphasis to graph anchors
    2 participants
    @AlexBxl @mck