Skip to content
This repository has been archived by the owner on Jun 12, 2019. It is now read-only.

Remove Effect type from makeDOMParser? #8

Open
bbarker opened this issue Apr 18, 2019 · 0 comments
Open

Remove Effect type from makeDOMParser? #8

bbarker opened this issue Apr 18, 2019 · 0 comments

Comments

@bbarker
Copy link
Contributor

bbarker commented Apr 18, 2019

This is a bit odd in that if enacted along with #7, would have the effect of completely swapping which functions are currently Effectful - since #7 adds Effect to parse functions, and I suggest removing it here; I couldn't find any explicit reason why new DOMParser should be effectful. The w3c docs do not seem to indicate IO or exceptions as a result of calling the constructor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant