Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support chain commands / viewing command string by default? #80

Closed
tony opened this issue Nov 10, 2017 · 2 comments
Closed

Support chain commands / viewing command string by default? #80

tony opened this issue Nov 10, 2017 · 2 comments
Labels

Comments

@tony
Copy link
Member

tony commented Nov 10, 2017

#79 (comment)

This could have a potential break in the API, commands would be required to have .execute() to run.

On the other hand, you would be able to view and even alter the raw string output of the command before running it. Highly valuable for debugging.

But it gets better, this could allow the use of chained commands separated by semicolons. This could substantially improve the performance of libtmux and tmuxp downstream.

Any feedback would be appreciated. I don't like breaking API's, but this seems like one that could be worth the investment.

@tony
Copy link
Member Author

tony commented Nov 10, 2017

One thing that'd have to be careful about with this is traversals breaking.

Methods may have to be separated between commands and traversals (moving between/up/down/searching tmux objects)

Depends on how it's implemented

@stale
Copy link

stale bot commented Jan 9, 2018

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.

This bot is used to handle issues where the issue hasn't been discussed or
has gone out of date. If an issue isn't resolved and handled in a certain
period of time, it may be closed. If you would like your issue re-opened,
please create a fresh issue with the latest, up to date information and
mention this issue in it.

@stale stale bot added the stale label Jan 9, 2018
@stale stale bot closed this as completed Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant