Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing -t to cmd() apis breaks running some progrmas #169

Open
ficoos opened this issue Jan 11, 2019 · 2 comments
Open

passing -t to cmd() apis breaks running some progrmas #169

ficoos opened this issue Jan 11, 2019 · 2 comments

Comments

@ficoos
Copy link

ficoos commented Jan 11, 2019

For all objects passing "-t" somewhere in the cmd overrides the object being referenced.
This breaks running commands that have -t in them (e.g. ssh).

pane.cmd('respawn-pane', 'ssh', '-t', 'user@host')
@tony
Copy link
Member

tony commented Jan 22, 2019

@ficoos Hm. Can we have a PR and a test case made for this?

Maybe #79 will help

@ficoos
Copy link
Author

ficoos commented Jan 23, 2019

It's actually a pervasive part of the API (it's in all objects). It was not a good decision IMHO and I would gladly see it change. I can modify the API so that it always injects the appropriate '-t' for the calling object. This will mean that only the Server can be used to send command to a random target (which is fine by me).
This change will break existing users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants