Bcsymbolmap hash differs when uploading and downloading #218
Comments
|
Can you elaborate on your Cartfile? What platforms are you uploading/downloading for? bcsymbolmaps ids are generated for all platforms. It's ok for them to be missing for the platforms you don't build for. Integration tests cover this scenario and I don't see any discrepancies https://github.com/tmspzz/Rome/blob/master/integration-tests/dynamic-frameworks-yml.bats |
|
I did another small test with a smaller project. Cartfile.resolved: Romefile: And when running: And when running: |
|
Thanks, I'll take a look asap |
|
Here is my test: And here are the bcsymbolmaps uuids for SwiftyBeaver iOS I don't see a discrepancy in the bcsymbolmaps' UUIDs that are uploaded and downloaded. Some bcsymbolmaps are missing because there are no bcsymbolmaps produced for that architecture. |
|
@jimmya maybe it's relate to the use of the engine. Can you try without and just with the local cache like I did? |
|
@jimmya any idea? |
|
I'm sorry for my late reply @tmspzz I tried without the engine and only local cache and then it works fine. I'm puzzled. Could you perhaps look at my engine and see if you can spot an obvious mistake: #!/usr/bin/env bash
set -e
ACTION="$1"
GREEN='\033[0;32m'
ORANGE='\033[0;33m'
RED='\033[0;31m'
NC='\033[0m' # No Color
info () {
printf "${ORANGE}$1${NC}\n"
}
success () {
printf "${GREEN}$1${NC}\n"
}
error () {
printf "${RED}$1${NC}\n"
}
ARTIFACTORY_DESTINATION="https://redacted"
AUTH_HEADER="X-JFrog-Art-Api"
API_KEY=`cat ~/.artifactory/key`
if [ "$ACTION" == "upload" ]; then
LOCAL_PATH="$2"
REMOTE_PATH="$3"
DIR=`echo "$LOCAL_PATH" | cut -d/ -f1`
info "Upload $LOCAL_PATH to $REMOTE_PATH"
http_code=$(curl --http1.1 -LI "$ARTIFACTORY_DESTINATION$REMOTE_PATH" -o /dev/null -w '%{http_code}\n' -s)
if [ ${http_code} -eq 200 ]; then
success "File already exists"
else
http_code=$(curl --http1.1 -H "$AUTH_HEADER: $API_KEY" -T "$LOCAL_PATH" "$ARTIFACTORY_DESTINATION$REMOTE_PATH" -o /tmp/curl-output -w '%{http_code}\n' -s)
if [ ${http_code} -eq 201 ]; then
success "Uploaded $LOCAL_PATH to $REMOTE_PATH"
else
error "Error: Failed to upload $LOCAL_PATH"
CURL_OUTPUT=`cat /tmp/curl-output`
error "$CURL_OUTPUT"
fi
fi
# Cleanup
rm -rf "$DIR"
elif [ "$ACTION" == "download" ]; then
REMOTE_PATH="$2"
OUTPUT_PATH="$3"
info "Download $REMOTE_PATH to $OUTPUT_PATH"
http_code=$(curl --http1.1 --create-dirs -s -f -o "$OUTPUT_PATH" "$ARTIFACTORY_DESTINATION$REMOTE_PATH" -w '%{http_code}\n' -s)
if [ ${http_code} -eq 200 ]; then
success "Downloaded $REMOTE_PATH to $OUTPUT_PATH"
else
error "Error: Failed to download $REMOTE_PATH"
fi
elif [ "$ACTION" == "list" ]; then
REMOTE_PATH="$2"
http_code=$(curl --http1.1 -LI "$ARTIFACTORY_DESTINATION$REMOTE_PATH" -o /dev/null -w '%{http_code}\n' -s)
if [ ${http_code} -ne 200 ]; then
exit 1
fi
else
error "Error: Unsupported command: $ACTION"
exit 1
fi
|
|
Hi, I'm using the script from @jimmya for the same purpose. I can see the same error as he's describing it. Here is my console output while uploading "nantes" library While here the output while downloading "nantes": Any idea @tmspzz ? |
|
Run before uploading all uuids should match. Repeat the same with dSYMs |
|
Before uploading (right after The rest is available in my previous post. And you can see that from the upload logs, Rome is not uploading the symbols for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Enhancement Suggestion / Bug Report
I noticed when running the download command the hashes for the bcsymbolmap file is different than when running the upload command. This results in errors when downloading the bcsymbolmap file.
Steps which explain the enhancement or reproduce the bug
in my case:
and
in my case:
and
Is there a reason these are different? Both commands are ran directly after each other so I wouldn't expect any differences.
Rome version:
0.23.2.63
OS and version:
10.15.3 (19D76)
The text was updated successfully, but these errors were encountered: