Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for timeout option #3

Open
mbello opened this issue Jan 15, 2019 · 1 comment
Open

Support for timeout option #3

mbello opened this issue Jan 15, 2019 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@mbello
Copy link

mbello commented Jan 15, 2019

Hi, thanks for odooly!

I am experienced with odoorpc and immediatelly I missed the timeout parameter when setting the connection parameters. Some requests take quite long and it is important to have a configurable timeout.

@florentx
Copy link
Member

florentx commented Jan 16, 2019

There's 2 ways right now to customize the timeout:

Maybe I'll add an optional argument to the Client as well, as an enhancement.
The tricky part is that odooly.Client uses either urllib.request or xmlrpc.clientor requests depending on the context and the configuration.

@florentx florentx added enhancement New feature or request question Further information is requested labels Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants