Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Warning and Error colours, Currently highlighted issue in Problems, are Invisible in Light theme #32

Open
stellarpower opened this issue Nov 16, 2021 · 5 comments

Comments

@stellarpower
Copy link

Hey,

Love the theme. But one thing that's been really frustrating is that one colour in particular seems to come out invisible, as light on a light background. I'm assuming, it could be a quirk in my system, but I finally switched over to a different light theme to see and it was fixed.

For me, it's the colour that the currently selected line in the Problems pane is. I've also just installed the output colouriser extension, and the same issue for the colour that warnings and errors are shown up as. Which is great as that's the only reason I installed it! :P

Including some screenshots of how it looks for me.
Possibly related is #30.

Problems pane:

image

Colourised output pane:

image

image

@tinacious
Copy link
Owner

Thanks so much for creating this issue! That definitely looks like a problem. I appreciate you taking the time to report this bug.

Can you provide an example project and steps to reproduce? It looks like one of the steps is to install the output coloriser plugin you noted, I'm wondering if there's a sample project I can use to see this.

@stellarpower
Copy link
Author

You're welcome! I think it simply ought to come up if there are any issues in the build process for any project, unless it's something specific that's happening to me - does that happen for you?

@stellarpower
Copy link
Author

image
image
Another place I forgot - errors in JSON. Can be tricky as I can't see what I'm doing! To reproduce, try to add an item to an array of strings, but leave off the initial quote.

@tebievx
Copy link

tebievx commented Apr 29, 2023

image

stellarpower added a commit to stellarpower/vscode-tinacious-design-syntax that referenced this issue Apr 30, 2023
Fix for tinacious#32, using arbitrary colour for now but feel free to modify of course.
@stellarpower
Copy link
Author

Thanks @tebievx ! Opening a patch above for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants