Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorship_threshold_percent ignored #72

Open
christophhillisch opened this issue Feb 22, 2023 · 3 comments
Open

Authorship_threshold_percent ignored #72

christophhillisch opened this issue Feb 22, 2023 · 3 comments

Comments

@christophhillisch
Copy link

christophhillisch commented Feb 22, 2023

I am running into the problem that configurations beyond the first one (show_contribution: true) are ignored. I set authorship_threshold_percent: 10, but I found contributions of 0.88 %.

Package Versions:

  • mkdocs 1.4.2
  • mkdocs-git-authors-plugin 0.7.0
  • mkdocs-git-revision-date-localized-plugin 1.1.0
  • mkdocs-material 9.0.13
  • mkdocs-material-extensions 1.1.1
  • python 3.10

Relevant parts in mkdocs.yml:

plugins:
  - search:
      lang: en
  - git-revision-date-localized:
      enable_creation_date: true
      fallback_to_build_date: false
      timezone: Europe/Paris
  - git-authors:
      show_contribution: true
      sort_authors_by: contribution
      authorship_threshold_percent: 10
@xsa
Copy link

xsa commented Apr 21, 2023

I'm seeing the same behaviour where contributors below the threshold are still shown.

Also, when using sort_authors_by: contribution instead of name, it does not sort them by name anymore, but the order (%) of contribution is not correct.

Using:

  • mkdocs==1.4.0
  • mkdocs-git-authors-plugin==0.6.4
  • mkdocs-git-revision-date-localized-plugin==1.0.1
  • mkdocs-material==8.5.11
  • mkdocs-material-extensions==1.1.1

@aazraq
Copy link

aazraq commented Apr 22, 2023

I also have the same issue.

@timvink
Copy link
Owner

timvink commented May 22, 2023

Thanks for reporting, I will need to look into this when I can make time again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants