-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature geoid #34
Merged
Merged
Feature geoid #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix include path - C++Now 2017: Daniel Pfeifer "Effective CMake" * https://www.youtube.com/watch?v=bsXLMQ6WgIk
- Latitude is in [-90, 90], longitude in [-180, 180]
- No altitude conversion for KML import (altitudes are already "above sea level")
- FIX: properly convert altitude to meters before WGS84 ellipsoid -> geoid conversion
- Make sure that the proper c++ compiler is selected in the Qt toolkit (Qt Creator) - Namely: /Applications/Xcode.app/Contents/Developer/Toolchains/ XcodeDefault.xctoolchain/usr/bin/c++
- Automatically initialise git submodules when configuring build system (when executing cmake)
- Introduce SD_FETCH_EGM option (cmake - default: OFF)
- Check for existence in the expected Resources directory - macOS: within the app bundle (Resources subfolder)
- INTERFACE or LIBRARY, but not CUSTOM targets
till213
added a commit
that referenced
this pull request
Dec 3, 2022
* Add geographiclib v1.52 * Add GeographicLib as dependency (WIP - won't compile on Windows) * Update README.md * Update README.md * Refactor CMakeLists.txt - Fix include path - C++Now 2017: Daniel Pfeifer "Effective CMake" * https://www.youtube.com/watch?v=bsXLMQ6WgIk * Add EGM2008 geoid with 5' resolution * Add GeographicLib info * Fix latitude/longitude range - Latitude is in [-90, 90], longitude in [-180, 180] * Add altitude conversion option to IGC import - No altitude conversion for KML import (altitudes are already "above sea level") * Add altitude conversion geoid -> WGS84 ellipsoid to IGC export * Bump logbook version to 0.11 * GPX export: convert to height above WGS84 ellipsoid - FIX: properly convert altitude to meters before WGS84 ellipsoid -> geoid conversion * Move the WGS84 ellipsoid <-> EGM geoid height conversions to Convert * Fix initialisation order * Remove -lc++ linker dependency (macOS) - Make sure that the proper c++ compiler is selected in the Qt toolkit (Qt Creator) - Namely: /Applications/Xcode.app/Contents/Developer/Toolchains/ XcodeDefault.xctoolchain/usr/bin/c++ * Prepare download of EGM file (cmake) * Fix logbook date selection column width * Update * Modernise cmake - Automatically initialise git submodules when configuring build system (when executing cmake) * Update build instructions: GIT_INIT_SUBMODULE option * Optionally download earth gravity model (EGM) - Introduce SD_FETCH_EGM option (cmake - default: OFF) * Place EGM files into app bundle (macOS) * Delete singletons only after main window * EGM file path settings - Check for existence in the expected Resources directory - macOS: within the app bundle (Resources subfolder) * Disable altitude conversion checkbox if no EGM available * INTERFACE targets do not support POST custom commands * Can only link to actual targets - INTERFACE or LIBRARY, but not CUSTOM targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for earth gravity model (EGM 2008).