Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carto URI localization regex bug #76

Closed
ansis opened this issue Sep 22, 2012 · 1 comment
Closed

Carto URI localization regex bug #76

ansis opened this issue Sep 22, 2012 · 1 comment

Comments

@ansis
Copy link
Contributor

ansis commented Sep 22, 2012

Millstone tries localizing bare urls in comments. While #74 addresses commented out urls, millstone should try to localize only urls within url(). Is there any reason the requirement for the url to be within url() was removed? @springmeyer

https://github.com/mapbox/millstone/blob/master/lib/millstone.js#L431
@ansis ansis mentioned this issue Sep 22, 2012
Closed
@springmeyer
Copy link
Member

This was fixed in a hacky way in 17f94cc#L0R423.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@springmeyer @ansis