Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork ? alternative ? #101

Closed
bflorat opened this issue Jan 28, 2022 · 13 comments
Closed

Fork ? alternative ? #101

bflorat opened this issue Jan 28, 2022 · 13 comments

Comments

@bflorat
Copy link
Contributor

bflorat commented Jan 28, 2022

This project seems abandoned by it original author still 2019.

I still thank him for his great piece of code and as an open source project admin myself, I understand very well that this he ows nothing to us.

However, it is paramount for some of my professional projects and I choosed it when very active back in 2018. I suppose I'm not the only one in this case.

Does somebody know an alternative ? think about a serious fork ?

@crgardner
Copy link

@bflorat - did you find alternatives after you posted?

@bflorat
Copy link
Contributor Author

bflorat commented Mar 23, 2022

@crgardner No but I didn't actively searched.

Note that I had to fork this project to fix #32. I forked this project to fix this. It is available on Maven central at

  <dependency>
            <groupId>net.florat</groupId>
            <artifactId>docx-stamper</artifactId>
            <version>1.4.0~1</version>
        </dependency>

Let me know if you find an alternative.

@dallanmc
Copy link

I got rid of all that index stuff in the codebase. You can just delete the object by getting the parent and then calling remove on it and pass in the object you want to remove. It greatly simplified the codebase.

@bflorat
Copy link
Contributor Author

bflorat commented Mar 23, 2022

Thanks. I don't remember well but it must be more or less what I did here

I also restored the maven packaging, I don't use gradle.

@crgardner
Copy link

crgardner commented Mar 23, 2022 via email

@caring-coder
Copy link

caring-coder commented May 14, 2022

I'm interested in an active fork as well, we are getting more and more invested in this piece of code at my workplace.
If any of you want to start and maintain an open source fork, we could participate.

If not, i believe we will do it ourselves anyway.

@bflorat
Copy link
Contributor Author

bflorat commented Jun 8, 2022

I'd like to but I for one have absolutely not the time to do it seriously.

Let us know if you start a fork, I may send MR.

@caring-coder
Copy link

caring-coder commented Sep 9, 2022

We are starting to actively fork the repo
You can find it here : https://github.com/verronpro/docx-stamper.
We started find improving the repeatDocPart, and making it recursive, and learning the way to publish to maven central. Thanks for the inspiration!
@AL1047088

@dallanmc
Copy link

dallanmc commented Sep 9, 2022

This is great - I have a good few improvements that I have implemented (they are in the issues section) - but maybe you've implemented some of them already. A couple of useful ones would be the displayWordIf processor and the displaySectionIf processor.
I also implemented the concept of preprocessors. I was facing an issue where spelling errors in the document would mess up the processing, so one preprocessor I made would remove all the spelling errors from the xml doc before then processing properly.
I also implemented a replaceWordsWith for commenting around multiple words which works well.

I am sure there is other stuff, but it's probably in the issues section too.

@bflorat
Copy link
Contributor Author

bflorat commented Sep 10, 2022

This is great ! I'll re-send you this PR #46 ASAP to fix the most important issue I have with this project.

@bflorat bflorat closed this as completed Sep 10, 2022
@caring-coder
Copy link

This is great - I have a good few improvements that I have implemented (they are in the issues section) - but maybe you've implemented some of them already. A couple of useful ones would be the displayWordIf processor and the displaySectionIf processor. I also implemented the concept of preprocessors. I was facing an issue where spelling errors in the document would mess up the processing, so one preprocessor I made would remove all the spelling errors from the xml doc before then processing properly. I also implemented a replaceWordsWith for commenting around multiple words which works well.

I am sure there is other stuff, but it's probably in the issues section too.

Thanks @dallanmc, you can make the merge requests yourself on https://github.com/verronpro/docx-stamper with maybe a test case, and i'll include them. If not, then i might take them on myself during the coming month.

@bflorat
Copy link
Contributor Author

bflorat commented Sep 12, 2022

Good work everybody ! Does the repeatDocPart() feature actually works now ? (even when elements are removed).

If it works now, I may try it again.

@caring-coder
Copy link

I did not try concurrently with the remove feature, but the repeatDocPart works and use only the given object as sub-context for the "doc part" covered by the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants