You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First off, this library is great so thanks for making it!
I just wrote a quick set of tests to validate our site, but we have a few pages that always take longer than 2 seconds to load(magento, yuck). anyways, I don't see any way to define a longer timeout. So I dug into your code and found it to be as easy as
Is this something you would be willing to accept a PR for? If so, how would you go about implementing it? This works and keeps the default basically the same as the defaults for the request library. I don't find the 'response' and 'deadline' verbage useful or meaningful at all, so I just used timeout and computed it to match the defaults. I'd be happy to handle it a better way however :)
The text was updated successfully, but these errors were encountered:
First off, this library is great so thanks for making it!
I just wrote a quick set of tests to validate our site, but we have a few pages that always take longer than 2 seconds to load(magento, yuck). anyways, I don't see any way to define a longer timeout. So I dug into your code and found it to be as easy as
and then passing in
Is this something you would be willing to accept a PR for? If so, how would you go about implementing it? This works and keeps the default basically the same as the defaults for the request library. I don't find the 'response' and 'deadline' verbage useful or meaningful at all, so I just used timeout and computed it to match the defaults. I'd be happy to handle it a better way however :)
The text was updated successfully, but these errors were encountered: