Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name/Surname reversed for Japan #86

Open
okonomiyaki3000 opened this issue Mar 23, 2016 · 2 comments
Open

Name/Surname reversed for Japan #86

okonomiyaki3000 opened this issue Mar 23, 2016 · 2 comments

Comments

@okonomiyaki3000
Copy link

This api is returning personal names like 'Daisuke' as surname and family names like 'Goto' as name. I suspect this has something to do with the fact that Japanese place the family name before the given name and probably other countries that do the same will have the same problem.

@thm
Copy link
Owner

thm commented Mar 23, 2016

Hey @okonomiyaki3000, currently regions can have an exceptions string, which Japan has too:

{
   "region":"Japan",
   "male":["昭一", ... ,"朝陽"],
   "female":["久美子", ... ,"愛梨"],
   "surnames":["佐藤", ... ,"中川"],
   "exceptions":[["/^(.*) (.*)$/","$2 $1"]] <-- first and last names ($1 and $2) are swapped
},

Are you saying that the name swapping is not working properly anymore? or just that the labeling in the returned JSON (name and surname) are not good representations of their values?

@okonomiyaki3000
Copy link
Author

I'm talking about the labeling. I'm not sure how the exceptions string comes into play but, if use the api like: http://api.uinames.com/?country=japan I will get a name which is actually a family name and a surname which is actually a given name. As it is, it's fine if the display logic used by any consumer of the api is simply: display name first, then display surname. But the ordering of names is a cultural/regional issue, not one that's intrinsic to the name itself. I live in Japan but I don't have a Japanese name. Yet, my name is often displayed or spoken family name first, given name second. Likewise, when Japanese people visit western countries, their names are always used in the local style. So, in my opinion, the data returned by the api should be correctly labelled and leave the display logic up to the consumer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants