Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone numbers in US format #103

Open
tjotala opened this issue Mar 29, 2017 · 1 comment
Open

Phone numbers in US format #103

tjotala opened this issue Mar 29, 2017 · 1 comment

Comments

@tjotala
Copy link
Contributor

tjotala commented Mar 29, 2017

The uinames.com site and extended usage API returns mock phone numbers in the US format (implied country code "+1"). This would be incorrect for any other country. I suggest one of two possible solutions:

  1. Return phone numbers formatted appropriately for each country.
  2. Return phone numbers as separate components (country code, area code, phone number) and leave the formatting to the user.

In either case, names.json would need to be extended to include the country code and plausible area codes for each region.

@srl295
Copy link

srl295 commented Mar 28, 2018

consider using https://github.com/googlei18n/libphonenumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants