From e5dbbda0cadce44ecf63ca30801f7f4d9e083027 Mon Sep 17 00:00:00 2001
From: Sophie Methe <sophie.methe@freenet.de>
Date: Tue, 9 Jul 2024 10:50:54 +0200
Subject: [PATCH] Add feature to display current membership count (#1675)

---
 .../group-selection.component.html            |  6 ++----
 .../group-selection.component.ts              | 21 ++++++++++++++++---
 2 files changed, 20 insertions(+), 7 deletions(-)

diff --git a/modules/fbs-core/web/src/app/page-components/course-detail/group-selection/group-selection.component.html b/modules/fbs-core/web/src/app/page-components/course-detail/group-selection/group-selection.component.html
index a306c0905..1266005b2 100644
--- a/modules/fbs-core/web/src/app/page-components/course-detail/group-selection/group-selection.component.html
+++ b/modules/fbs-core/web/src/app/page-components/course-detail/group-selection/group-selection.component.html
@@ -16,9 +16,8 @@
       <th>{{ "course.select-group" | i18nextEager }}</th>
       <th>{{ "course.group" | i18nextEager }}</th>
       <th>{{ "course.group-membership" | i18nextEager }}</th>
-      <!--<th>Mitglieder</th>-->
     </tr>
-    <tr *ngFor="let group of groups | async; let i = index">
+    <tr *ngFor="let group of groups$ | async; let i = index">
       <td>
         <input
           type="radio"
@@ -29,8 +28,7 @@
         />
       </td>
       <td>{{ group.name }}</td>
-      <td>{{ group.membership }}</td>
-      <!--<td><td>{{ group.members.join(', ') }}</td> >-->
+      <td>{{ group.currentMembership }} / {{ group.membership }}</td>
     </tr>
   </table>
   <button
diff --git a/modules/fbs-core/web/src/app/page-components/course-detail/group-selection/group-selection.component.ts b/modules/fbs-core/web/src/app/page-components/course-detail/group-selection/group-selection.component.ts
index e478d1c60..5ea07fa56 100644
--- a/modules/fbs-core/web/src/app/page-components/course-detail/group-selection/group-selection.component.ts
+++ b/modules/fbs-core/web/src/app/page-components/course-detail/group-selection/group-selection.component.ts
@@ -1,7 +1,7 @@
 import { Component, Input, OnInit } from "@angular/core";
 import { ActivatedRoute } from "@angular/router";
 import { AuthService } from "../../../service/auth.service";
-import { Observable } from "rxjs";
+import { forkJoin, Observable } from "rxjs";
 import { Requirement } from "../../../model/Requirement";
 import { MatDialog } from "@angular/material/dialog";
 import { Roles } from "../../../model/Roles";
@@ -9,6 +9,7 @@ import { NewGroupDialogComponent } from "../../../dialogs/new-group-dialog/new-g
 import { Group } from "../../../model/Group";
 import { GroupService } from "../../../service/group.service";
 import { GroupRegistrationService } from "../../../service/group-registration.sevice";
+import { map, mergeMap } from "rxjs/operators";
 
 @Component({
   selector: "app-group-selection",
@@ -18,7 +19,7 @@ import { GroupRegistrationService } from "../../../service/group-registration.se
 export class GroupSelectionComponent implements OnInit {
   @Input() requirements: Observable<Requirement[]>;
 
-  groups: Observable<Group[]>;
+  groups$: Observable<(Group & { currentMembership: number })[]>;
   selectedGroup: Group;
   courseId: number;
   editGroups: boolean = false;
@@ -51,7 +52,21 @@ export class GroupSelectionComponent implements OnInit {
   }
 
   loadGroups(): void {
-    this.groups = this.groupService.getGroupList(this.courseId);
+    this.groups$ = this.groupService
+      .getGroupList(this.courseId)
+      .pipe(
+        mergeMap((groups: Group[]) =>
+          forkJoin(
+            groups.map((group) =>
+              this.groupRegistrationService
+                .getGroupMembership(this.courseId, group.id)
+                .pipe(
+                  map((currentMembership) => ({ ...group, currentMembership }))
+                )
+            )
+          )
+        )
+      );
   }
 
   createGroup() {